https://codereview.appspot.com/6775058/diff/1/app/views/charm-search.js File app/views/charm-search.js (right):
https://codereview.appspot.com/6775058/diff/1/app/views/charm-search.js#newcode31 app/views/charm-search.js:31: parseInt(scrollContainer.getComputedStyle('height'), 10)), Does node.get('clientHeight') not work for this case?
https://codereview.appspot.com/6775058/diff/1/app/views/charm-search.js#newcode597 app/views/charm-search.js:597: svg && parseInt(Y.one('svg').getAttribute('height'), 10) + 17}; You dont need to call "Y.one" again. You already have the svg object. What happens when we have no svg object?
https://codereview.appspot.com/6775058/diff/1/app/views/charm-search.js#newcode655 app/views/charm-search.js:655: // if (sub) { sub.detach(); } You don't use the sub object. Do you need the loop?
https://codereview.appspot.com/6775058/
« Back to merge proposal
https:/ /codereview. appspot. com/6775058/ diff/1/ app/views/ charm-search. js charm-search. js (right):
File app/views/
https:/ /codereview. appspot. com/6775058/ diff/1/ app/views/ charm-search. js#newcode31 charm-search. js:31: scrollContainer .getComputedSty le('height' ), 10)), 'clientHeight' ) not work for this case?
app/views/
parseInt(
Does node.get(
https:/ /codereview. appspot. com/6775058/ diff/1/ app/views/ charm-search. js#newcode597 charm-search. js:597: svg && Y.one(' svg').getAttrib ute('height' ), 10) + 17};
app/views/
parseInt(
You dont need to call "Y.one" again. You already have the svg object.
What happens when we have no svg object?
https:/ /codereview. appspot. com/6775058/ diff/1/ app/views/ charm-search. js#newcode655 charm-search. js:655: // if (sub) { sub.detach(); }
app/views/
You don't use the sub object. Do you need the loop?
https:/ /codereview. appspot. com/6775058/