Code review comment for lp://staging/~gary/juju-gui/bug1250547
Revision history for this message
| Gary Poster (gary) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
*** Submitted:
Simplify bundle vis centering
It turns out that using a polygon centroid isn't quite what our eyes
expected, and also caused a bug when elements were away from the center
mass of services. Using the bounding box gives more expected results.
I didn't add a test, because I argued to myself that this was a visual
thing, but I'm really lying to myself, and if you want to call me out on
it, please feel free to appeal to my better self. :-)
To QA, look at a lot of bundles, like those from "hatch", "jorge", and
"gary". Then also look at the problematic one,
http://
. Compare it with the rendering in trunk (like on comingsoon) to see
the difference.
R=matthew.scott
CC=
https:/
https:/