Merge lp://staging/~gary/juju-gui/bug1228166 into lp://staging/juju-gui/experimental
Proposed by
Gary Poster
Status: | Merged |
---|---|
Merged at revision: | 1084 |
Proposed branch: | lp://staging/~gary/juju-gui/bug1228166 |
Merge into: | lp://staging/juju-gui/experimental |
Diff against target: |
431 lines (+239/-76) 6 files modified
app/templates/unitOverview.handlebars (+8/-10) app/views/databinding.js (+13/-4) app/views/viewlet-manager.js (+6/-17) app/views/viewlets/unit-details.js (+96/-17) docs/viewlets.rst (+1/-1) test/test_unit_detail_viewlet.js (+115/-27) |
To merge this branch: | bzr merge lp://staging/~gary/juju-gui/bug1228166 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju GUI Hackers | Pending | ||
Review via email:
|
Description of the change
Data-bind unit details view
Our unit detail view was not data-bound: it would render and never update. This branch fixes that, except for the relation information, which is not really available at the moment (in terms of errors) so I decided that could live to fight another day.
To post a comment you must log in.
Reviewers: mp+187311_ code.launchpad. net,
Message:
Please take a look.
Description:
Data-bind unit details view
Our unit detail view was not data-bound: it would render and never
update. This branch fixes that, except for the relation information,
which is not really available at the moment (in terms of errors) so I
decided that could live to fight another day.
To qa, deploy a service, turn off the simulator (to avoid surprises),
open the unit view of unit 0, and try the following in the console,
looking on in the unit details view as you do.
myunit = app.db. units.item( 0) private_ address = '10.0.0.1' public_ address = '10.0.0.2' agent_state_ info = 'great!' environment. set('annotation s', {'landscape-url': landscape. example. com','landscape -computers': criteria/ environment: test'}) computer' : 'kumquat'}
myunit.
myunit.
myunit.open_ports = [80]
myunit.open_ports = [8080]
myunit.open_ports = [443]
myunit.open_ports = [443, 8080]
myunit.
app.db.
'http://
'/computers/
myunit.annotations = {'landscape-
(note that the app.dp. environment. set call does not trigger a change in
the view: it sets up data for the next mutation, which does.)
Thank you!
https:/ /code.launchpad .net/~gary/ juju-gui/ bug1228166/ +merge/ 187311
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/13841044/
Affected files (+235, -55 lines): unitOverview. handlebars viewlet- manager. js viewlets/ unit-details. js unit_detail_ viewlet. js
A [revision details]
M app/templates/
M app/views/
M app/views/
M test/test_