Code review comment for lp://staging/~gary/juju-core/more-info

Revision history for this message
William Reade (fwereade) wrote :

LGTM -- maybe ping me tomorrow about status and status info?

https://codereview.appspot.com/8086045/diff/1/state/api/params/params.go
File state/api/params/params.go (right):

https://codereview.appspot.com/8086045/diff/1/state/api/params/params.go#newcode340
state/api/params/params.go:340: StatusInfo string
Hmm, there may be some changes to status landing shortly. How bad would
it be for you if statuses were to move off the unit document and into
their own collection? I guess it'd be more megawatcher work, but I guess
there may be further consequences on your side?

https://codereview.appspot.com/8086045/diff/1/state/api/params/params_test.go
File state/api/params/params_test.go (right):

https://codereview.appspot.com/8086045/diff/1/state/api/params/params_test.go#newcode55
state/api/params/params_test.go:55: Series: "series", // E.g. precise.
On 2013/04/01 20:46:58, thumper wrote:
> Can we change the test so instead of using comments for "precise" and
> "wordpress" we instead have the test output show this?

+1

https://codereview.appspot.com/8086045/

« Back to merge proposal