Code review comment for lp://staging/~gary/juju-core/more-info

Revision history for this message
Gary Poster (gary) wrote :

Reviewers: mp+156406_code.launchpad.net,

Message:
Please take a look.

Description:
Expose more delta information

This exposes more unit attributes to the watchers. The only true
additions in this branch are to the params.go file, and the associated
test. After this change, much more (but unfortunately still not all) of
the values we need will be exposed in the watcher.

The branch is very large because of mechanical changes that prevent
circular imports. UnitStatus, Port, and ResolvedMode needed to move
into the params package, and this required a very large number of
mechanical import changes. The rest of the changes in this branch,
other than some test fix-ups in megawatcher_internal_test.go, are just
these mechanical changes to handle the new location.

https://code.launchpad.net/~gary/juju-core/more-info/+merge/156406

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/8086045/

Affected files:
   A [revision details]
   M cmd/builddb/main.go
   M cmd/juju/resolved_test.go
   M cmd/juju/status.go
   M cmd/juju/status_test.go
   M cmd/jujud/unit_test.go
   M environs/dummy/environs.go
   M environs/ec2/ec2.go
   M environs/interface.go
   M environs/jujutest/livetests.go
   M environs/openstack/provider.go
   M juju/conn.go
   M juju/conn_test.go
   M state/api/params/params.go
   M state/api/params/params_test.go
   M state/apiserver/api_test.go
   M state/machine_test.go
   M state/megawatcher_internal_test.go
   M state/service.go
   M state/state_test.go
   M state/statecmd/resolved.go
   M state/statecmd/resolved_test.go
   M state/unit.go
   M state/unit_test.go
   M worker/firewaller/firewaller.go
   M worker/firewaller/firewaller_test.go
   M worker/uniter/filter.go
   M worker/uniter/filter_test.go
   M worker/uniter/modes.go
   M worker/uniter/uniter_test.go

« Back to merge proposal