https://codereview.appspot.com/7563046/diff/1/state/api/apiclient.go#newcode143
state/api/apiclient.go:143: func (watcher *AllWatcher) Next()
(*[]params.Delta, error) {
On 2013/03/07 18:05:24, dimitern wrote:
> why not return just []params.Delta, error ? nil is a valid slice
value, if the
> pointer needs to express missing params.
Please take a look.
https:/ /codereview. appspot. com/7563046/ diff/1/ state/api/ apiclient. go apiclient. go (right):
File state/api/
https:/ /codereview. appspot. com/7563046/ diff/1/ state/api/ apiclient. go#newcode131 apiclient. go:131: type AllWatcher struct {
state/api/
On 2013/03/07 18:05:24, dimitern wrote:
> doc comment?
Done.
https:/ /codereview. appspot. com/7563046/ diff/1/ state/api/ apiclient. go#newcode137 apiclient. go:137: return &AllWatcher{
state/api/
On 2013/03/07 18:05:24, dimitern wrote:
> you need just &AllWatcher{client, id} here.
Done.
https:/ /codereview. appspot. com/7563046/ diff/1/ state/api/ apiclient. go#newcode143 apiclient. go:143: func (watcher *AllWatcher) Next()
state/api/
(*[]params.Delta, error) {
On 2013/03/07 18:05:24, dimitern wrote:
> why not return just []params.Delta, error ? nil is a valid slice
value, if the
> pointer needs to express missing params.
Done.
https:/ /codereview. appspot. com/7563046/ diff/1/ state/api/ params/ params. go params/ params. go (right):
File state/api/
https:/ /codereview. appspot. com/7563046/ diff/1/ state/api/ params/ params. go#newcode117 params/ params. go:117: func (d *Delta) UnmarshalJSON(data
state/api/
[]byte) error {
On 2013/03/07 18:05:24, dimitern wrote:
> // UnmarshalJSON implements json.Marshaller. ?
Done.
https:/ /codereview. appspot. com/7563046/ diff/1/ state/api/ params/ params. go#newcode137 params/ params. go:137: return fmt.Errorf( "Unexpected operation
state/api/
%#v", operation)
On 2013/03/07 18:05:24, dimitern wrote:
> s/%#v/%q/ ?
Done.
https:/ /codereview. appspot. com/7563046/ diff/1/ state/api/ params/ params. go#newcode149 params/ params. go:149: return fmt.Errorf( "Unexpected entity
state/api/
name %#v", entityKind)
On 2013/03/07 18:05:24, dimitern wrote:
> ditto
Done.
https:/ /codereview. appspot. com/7563046/