Juju Charms Collection
juju-gui package

Code review comment for lp://staging/~gary/charms/precise/juju-gui/credentialConfig

  1. Precise Pangolin (12.04)
  2. credentialConfig
  3. Merge into trunk
Revision history for this message
Gary Poster (gary) wrote :

On 2013/10/01 19:21:33, benji wrote:
> LGTM

> https://codereview.appspot.com/14226043/diff/1/Makefile
> File Makefile (right):

> https://codereview.appspot.com/14226043/diff/1/Makefile#newcode20
> Makefile:20: libpython-dev
> Most of the other line continuations use a tab and then four spaces.
Mixing
> tabs and spaces isn't the greatest thing in the world, but neither are
the deep,
> deep indents caused by all-tabs-all-the-time. I'm cool either way.

> https://codereview.appspot.com/14226043/diff/1/hooks/install
> File hooks/install (right):

> https://codereview.appspot.com/14226043/diff/1/hooks/install#newcode24
> hooks/install:24: # We need to install the Juju PPA, which we will do
with a
> It looks like this needs to be word wrapped with the line below.

Argh, sorry, I missed that you had requested changes. Fixing.

https://codereview.appspot.com/14226043/

« Back to merge proposal