Juju Charms Collection
juju-gui package

Code review comment for lp://staging/~gary/charms/precise/juju-gui/bug1117896

  1. Precise Pangolin (12.04)
  2. bug1117896
  3. Merge into trunk
Revision history for this message
Gary Poster (gary) wrote :

Thank you for the reply!

To make sure I understand your idea, you would say to users something like, "if you are using an older version of the GUI, set the socket URL on the charm so the GUI doesn't break." Is that right? If so, my concern is that the breakage is silent (the GUI just hangs while it fails to connect), and we don't have an opportunity to advise them what to do…and we can't rely on users to read deployment instructions IMO.

The advantage of your proposal is that it doesn't require any changes to the GUI. It already works as you describe.

I will think about the idea some more though. Thanks again! Talk to you tomorrow.

Gary

On Mar 12, 2013, at 9:48 PM, Jeff Pihach <email address hidden> wrote:

> Yes I agree with your proposal.
>
> I would take a slightly different approach - I would add a config option to allow the admin to specify the socket url at the charm level and have that reflected down to the GUI. Then in the GUI it would be pretty simple to check to see if the socket_url is specified, and if not, build it from the supplied components.
> --
> https://code.launchpad.net/~gary/charms/precise/juju-gui/bug1117896/+merge/152973
> You are the owner of lp:~gary/charms/precise/juju-gui/bug1117896.

« Back to merge proposal