Code review comment for lp://staging/~gary/charms/precise/juju-gui/bug1117896

Revision history for this message
Jeff Pihach (hatch) wrote :

Yes I agree with your proposal.

I would take a slightly different approach - I would add a config option to allow the admin to specify the socket url at the charm level and have that reflected down to the GUI. Then in the GUI it would be pretty simple to check to see if the socket_url is specified, and if not, build it from the supplied components.

« Back to merge proposal