Juju Charms Collection
juju-gui package

Code review comment for lp://staging/~gary/charms/precise/juju-gui/bug1117896

  1. Precise Pangolin (12.04)
  2. bug1117896
  3. Merge into trunk
Revision history for this message
Gary Poster (gary) wrote :

Unfortunately this is backwards incompatible. This is because GUI releases prior to 0.2.2 needed socket_protocol, so trying to use the charm with any earlier release breaks. I discovered this because the charm tests broke. It used 0.2.1.

I updated the tests to use 0.2.2, but that's not the right solution. We should make this backwards compatible if possible, at the very least when we notice that we are breaking something.

My proposal is that, in the GUI, we support a new socket value in the config: ignore_socket_url. If socket_url is set *or if ignore_socket_url is true* then we ignore socket_url, and build the address dynamically. Then the charm will set ignore_socket_url to True.

Alternatively, we could have the GUI look for the version number. I like my proposal better.

When we change the GUI, I would like to also document the new config options in the file as comments.

Once we change the GUI trunk, we should make another release, and then land this charm branch.

Thoughts?

« Back to merge proposal