Juju Charms Collection
buildbot-master package

Code review comment for lp://staging/~gary/charms/oneiric/buildbot-master/run-as-buildbot

  1. Oneiric (11.10)
  2. run-as-buildbot
  3. Merge into trunk
Revision history for this message
Gary Poster (gary) wrote :

All those helpers are taken from setuplxc.py, btw.

The su contextmanager has an issue: the euid and egid are not set back properly when there is an error in the with block, for some reason. This can cause some problems: for some reason the juju log command hangs when the buildbot user tries to use it. Benji and I took a quick look at it and did not see a reason why they would do this. Perhaps it takes a moment to propagate?

I have not yet run the existing tests. I will do this before landing, resolving any issues. That said, this will bring up a master and slave for lpbuildbot, and at least check out the branch. Subsequently there's an error within Twisted/Buildbot itself, but it's on the right track.

« Back to merge proposal