Changes look good. One oddity is that i'm seeing console output in the test runner when running the sudo upstart tests
ie.
TEST_SUDO=1 ./test juju/providers/local/tests/test_files.py [sudo] password for kapil: juju.providers.local.tests.test_files FileStorageTest test_get_url ... [OK] WebFileStorageTest test_capture_errors ... juju-borken-file-storage start/running, process 32115 juju-borken-file-storage stop/waiting [OK] test_namespacing ... juju-ns2-file-storage start/running, process 32136 juju-ns1-file-storage start/running, process 32149 juju-ns2-file-storage stop/waiting juju-ns1-file-storage stop/waiting [OK] test_start_invalid_directory ... [OK] test_start_missing_args ... [OK] test_start_stop ... juju-ns1-file-storage start/running, process 32178 juju-ns1-file-storage stop/waiting [OK] test_upstart ... [OK]
------------------------------------------------------------------------------- Ran 7 tests in 5.451s
« Back to merge proposal
Changes look good. One oddity is that i'm seeing console output in the test runner when running the sudo upstart tests
ie.
TEST_SUDO=1 ./test juju/providers/ local/tests/ test_files. py local.tests. test_files eTest capture_ errors ... juju-borken- file-storage start/running, process 32115 file-storage stop/waiting
[OK] namespacing ... juju-ns2- file-storage start/running, process 32136 file-storage start/running, process 32149 file-storage stop/waiting file-storage stop/waiting
[OK] start_invalid_ directory ... [OK] start_missing_ args ... [OK] file-storage start/running, process 32178 file-storage stop/waiting
[OK]
[sudo] password for kapil:
juju.providers.
FileStorageTest
test_get_url ... [OK]
WebFileStorag
test_
juju-borken-
test_
juju-ns1-
juju-ns2-
juju-ns1-
test_
test_
test_start_stop ... juju-ns1-
juju-ns1-
test_upstart ... [OK]
------- ------- ------- ------- ------- ------- ------- ------- ------- ------- ------- --
Ran 7 tests in 5.451s