Code review comment for lp://staging/~fwereade/pyjuju/restrict-relation-broken-context

Revision history for this message
William Reade (fwereade) wrote :

Thanks Kapil.

[0]

Good point, thanks.

[1]

Fair enough :).

[2]

I'll take a look at those.

[3]

I'd prefer to avoid that: (1) the mixin depends on .service and .context, which are not part of the TestBase, and (2) they do have different responsibilities, and it feels somewhat coincidental that all the subclasses currently happen to use both base classes' services.

« Back to merge proposal