Code review comment for lp://staging/~fwereade/juju-core/state-dying-service-fix

Revision history for this message
Tim Penhey (thumper) wrote :

LGTM - Generally hoping that one day we have tests that are more
understandable with less implied knowledge.

https://codereview.appspot.com/8748048/diff/1/state/unit_test.go
File state/unit_test.go (right):

https://codereview.appspot.com/8748048/diff/1/state/unit_test.go#newcode735
state/unit_test.go:735: c.Assert(err, IsNil)
It isn't obvious to me what these commands are here for at all. Perhaps
in the future we could have some higher level testing functions that
make the tests more readable and understandable dealing with higher
level concepts.

https://codereview.appspot.com/8748048/

« Back to merge proposal