Code review comment for lp://staging/~fwereade/juju-core/state-dying-service-fix

Revision history for this message
William Reade (fwereade) wrote :

https://codereview.appspot.com/8748048/diff/1/state/service.go
File state/service.go (right):

https://codereview.appspot.com/8748048/diff/1/state/service.go#newcode647
state/service.go:647: {"life", Dying},
On 2013/04/15 16:11:33, dimitern wrote:
> so this is: Dying, OR (unitcount>1 AND relationcount > 0), right?

This is Dying AND (unitcount>1 OR relationcount >0). To put it another
way: "there must be at least one other entity holding a reference to a
dying service at the point we remove a unit; if not, we should abort and
recalculate (and expect to hit the hasLastRef branch above)".

https://codereview.appspot.com/8748048/

« Back to merge proposal