Code review comment for lp://staging/~fwereade/juju-core/state-dying-service-fix

On 2013/04/15 16:44:53, dimitern wrote:
> I think you need to add removeOps to this case as well:
> ...
> rvba> fwereade: doesn't look like your fix worked:
> http://paste.ubuntu.com/5710819/
> dimitern> rvba: that wasn't the case before, right? the both the unit
and the
> service were in the status output
> rvba> dimitern: indeed (that was before the fix:
> http://paste.ubuntu.com/5710599/)
> dimitern> fwereade , rvba: I think the fix should include removeOps in
the
> amended case, like we're doing a bit further up in the "if s.doc.Life
== Dying
> && s.doc.RelationCount == 0 && s.doc.UnitCount == 1" case

Working as intended: mediawiki is in an error state, and is still
holding a ref to the relation, which is still holding a ref to the
service. `juju resolved mediawiki/0` will unblock it, and cause mysql to
be removed when mediawiki/0 departs the relation.

https://codereview.appspot.com/8748048/