Code review comment for lp://staging/~fwereade/juju-core/environs-tools-final-replacement
Revision history for this message
| William Reade (fwereade) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
9199653
demo site
(Get the code!)
Please take a look.
https:/
File cmd/juju/
https:/
cmd/juju/
public tools would be ignored")
On 2013/04/15 13:48:21, rog wrote:
> i think this should be just a warning, if anything.
> just because we have private tools present in the current environment
doesn't
> mean we don't want to make tools available to others in the public
bucket.
Honestly, I question the value of --public regardless. If I were setting
it up I'd have a shared-tools environ that I never actually used other
than to sync tools into, and use its control-bucket as my other
environs' public-bucket.
Given the current fallback rules, a public sync-tools into an env with
private tools will fail to perform the purpose of sync-tools -- make
them *available* to the target env -- and so I think it's actually
better to fail before performing a ineffectual copy of X MiB via one's
local machine.
https:/
cmd/juju/
tools.ErrNoTools:
On 2013/04/15 13:48:21, rog wrote:
> still pained by this.
Each non-test file that uses them together also needs to differentiate
between the two situations. I don't think it's unreasonable to have
distinct errors.
https:/
File cmd/juju/
https:/
cmd/juju/
"1.0.0-
On 2013/04/15 15:00:54, dimitern wrote:
> please, put these on separate lines (or at least one line per series).
heh, they're like this because I was trying to maintain consistency.
Done.
https:/