Juju Charms Collection
rabbitmq-server package

Merge lp://staging/~freyes/charms/trusty/rabbitmq-server/mirroring-queues into lp://staging/charms/trusty/rabbitmq-server

  1. Trusty Tahr (14.04)
  2. mirroring-queues
  3. Merge into trunk
Proposed by Felipe Reyes
Status: Superseded
Proposed branch: lp://staging/~freyes/charms/trusty/rabbitmq-server/mirroring-queues
Merge into: lp://staging/charms/trusty/rabbitmq-server
Diff against target: 345 lines (+231/-22)
8 files modified
.bzrignore (+2/-0)
Makefile (+17/-7)
config.yaml (+6/-0)
hooks/rabbit_utils.py (+106/-15)
hooks/rabbitmq_server_relations.py (+8/-0)
setup.cfg (+5/-0)
test-requirements.txt (+3/-0)
tests/40_test_mirroring_queues.py (+84/-0)
To merge this branch: bzr merge lp://staging/~freyes/charms/trusty/rabbitmq-server/mirroring-queues
Reviewer Review Type Date Requested Status
charmers Pending
Review Queue automated testing Pending
Review via email: mp+246936@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-01-19.

This proposal has been superseded by a proposal from 2015-01-19.

Description of the change

Dear Charmers,

This MP adds support for mirrored queues when the configuration key 'mirroring-queues' is set to True.

When this new configuration is True (which is the default) the charm will set a policy to all the vhosts, the policy sets ha-mode to 'all' and it applies to amqp exchanges and queues that match '^(?!amq\.).*'.

More details about how policies enable HA in rabbitmq can be found at http://www.rabbitmq.com/blog/2012/11/19/breaking-things-with-rabbitmq-3-0/ and http://www.rabbitmq.com./ha.html

Also this MP adds an amulet script to test the deployment of rabbitmq-server (2 units), this test declares a queue and publishes a message in one of the hosts, and then consumes the message from the other unit.

Thanks,

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #734 trusty-rabbitmq-server for freyes mp246249
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/734/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #705 trusty-rabbitmq-server for freyes mp246249
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/705/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #890 trusty-rabbitmq-server for freyes mp246249
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/890/

Revision history for this message
Nobuto Murata (nobuto) : Posted in a previous version of this proposal
Revision history for this message
Nobuto Murata (nobuto) wrote : Posted in a previous version of this proposal

I've tested this branch and left two inline comments. Otherwise it looks good to me.

HA policy for vhost 'openstack' was properly setup with mirroring-queues=True in my OpenStack deployment.

Revision history for this message
Review Queue (review-queue) wrote : Posted in a previous version of this proposal

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10951-results

review: Needs Fixing (automated testing)
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #881 trusty-rabbitmq-server for freyes mp246249
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/881/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #852 trusty-rabbitmq-server for freyes mp246249
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/852/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #1076 trusty-rabbitmq-server for freyes mp246249
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/1076/

Revision history for this message
Felipe Reyes (freyes) : Posted in a previous version of this proposal
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #853 trusty-rabbitmq-server for freyes mp246249
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/853/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #882 trusty-rabbitmq-server for freyes mp246249
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/882/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #1077 trusty-rabbitmq-server for freyes mp246249
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/1077/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #855 trusty-rabbitmq-server for freyes mp246936
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/855/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #884 trusty-rabbitmq-server for freyes mp246936
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
  Storing debug log for failure in /var/lib/jenkins/.pip/pip.log
  make: *** [.venv] Error 1

Full unit test output: http://paste.ubuntu.com/9787515/
Build: http://10.245.162.77:8080/job/charm_unit_test/884/

Revision history for this message
Jorge Niedbalski (niedbalski) wrote : Posted in a previous version of this proposal

Minor questions/comments, other than that LGTM.

review: Needs Fixing
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #1079 trusty-rabbitmq-server for freyes mp246936
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/1079/

lp://staging/~freyes/charms/trusty/rabbitmq-server/mirroring-queues updated
84. By Felipe Reyes

fixed raise RabbitmqError exception

85. By Felipe Reyes

Simplify vhost_exists() function

Revision history for this message
Jorge Niedbalski (niedbalski) wrote : Posted in a previous version of this proposal

Pretty good work Felipe, thanks for fixing.

LGTM

review: Approve

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches