Juju Charms Collection
rabbitmq-server package

Merge lp://staging/~freyes/charms/trusty/rabbitmq-server/mirroring-queues into lp://staging/charms/trusty/rabbitmq-server

Proposed by Felipe Reyes on 2015-01-13

Status:

Superseded

Proposed branch:

lp://staging/~freyes/charms/trusty/rabbitmq-server/mirroring-queues

Merge into:

lp://staging/charms/trusty/rabbitmq-server

Diff against target:

345 lines (+232/-21)

8 files modified

.bzrignore (+2/-0)
Makefile (+17/-7)
config.yaml (+6/-0)
hooks/rabbit_utils.py (+108/-14)
hooks/rabbitmq_server_relations.py (+8/-0)
setup.cfg (+5/-0)
test-requirements.txt (+2/-0)
tests/40_test_mirroring_queues.py (+84/-0)

To merge this branch:

bzr merge lp://staging/~freyes/charms/trusty/rabbitmq-server/mirroring-queues

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Review Queue (community)	automated testing	2015-01-13	Needs Fixing on 2015-01-16
charmers		2015-01-13	Pending
Review via email: mp+246249@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2015-01-19.

Description of the change

Dear Charmers,

This MP adds support for mirrored queues when the configuration key 'mirroring-queues' is set to True.

When this new configuration is True the charm will set a policy to all the vhosts, the policy sets ha-mode to 'all' and it applies to amqp exchanges and queues that match '^(?!amq\.).*'.

More details about how policies enable HA in rabbitmq can be found at http://www.rabbitmq.com/blog/2012/11/19/breaking-things-with-rabbitmq-3-0/ and http://www.rabbitmq.com./ha.html

Also this MP adds an amulet script to test the deployment of rabbitmq-server (2 units), this test declares a queue and publishes a message in one of the hosts, and then consumes the message from the other unit.

Thanks,

Revision history for this message

uosci-testing-bot (uosci-testing-bot) wrote on 2015-01-13:

charm_unit_test #734 trusty-rabbitmq-server for freyes mp246249
UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/734/

Revision history for this message

uosci-testing-bot (uosci-testing-bot) wrote on 2015-01-13:

charm_lint_check #705 trusty-rabbitmq-server for freyes mp246249
LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/705/

Revision history for this message

uosci-testing-bot (uosci-testing-bot) wrote on 2015-01-13:

charm_amulet_test #890 trusty-rabbitmq-server for freyes mp246249
AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/890/

Revision history for this message

Nobuto Murata (nobuto) on 2015-01-13:

Revision history for this message

Nobuto Murata (nobuto) wrote on 2015-01-14:

I've tested this branch and left two inline comments. Otherwise it looks good to me.

HA policy for vhost 'openstack' was properly setup with mirroring-queues=True in my OpenStack deployment.

Revision history for this message

Review Queue (review-queue) wrote on 2015-01-16:

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10951-results

review: Needs Fixing (automated testing)

lp://staging/~freyes/charms/trusty/rabbitmq-server/mirroring-queues updated on 2015-01-19

79. By Felipe Reyes on 2015-01-19

Changed mirroring-queues default to True

In the past (rabbitmq-server < 3.0), queue mirroring was enabled by default
this change honours the original default

80. By Felipe Reyes on 2015-01-19

Commit after pull/merge changes from trunk

Revision history for this message

uosci-testing-bot (uosci-testing-bot) wrote on 2015-01-19:

charm_unit_test #881 trusty-rabbitmq-server for freyes mp246249
UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/881/

Revision history for this message

uosci-testing-bot (uosci-testing-bot) wrote on 2015-01-19:

charm_lint_check #852 trusty-rabbitmq-server for freyes mp246249
LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/852/

Revision history for this message

uosci-testing-bot (uosci-testing-bot) wrote on 2015-01-19:

charm_amulet_test #1076 trusty-rabbitmq-server for freyes mp246249
AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/1076/

Revision history for this message

Felipe Reyes (freyes) on 2015-01-19:

lp://staging/~freyes/charms/trusty/rabbitmq-server/mirroring-queues updated on 2015-01-19

81. By Felipe Reyes on 2015-01-19: Create virtualenv to run unit tests
82. By Felipe Reyes on 2015-01-19: Remove ha-mode set to vhost '/' this is managed by mirroring-queues