Code review comment for lp://staging/~freyes/charms/trusty/nova-cloud-controller/single-nova-consoleauth

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Felipe, i'm deploying this as we speak. The code looks fine although I have a few comments about how it could be slightly neater, see inline. One approach might be so pull the relation_settings, travers the settings dict and apply any default/missing entries then process the results.

review: Needs Fixing

« Back to merge proposal