Juju Charms Collection
memcached package

Code review comment for lp://staging/~freyes/charms/trusty/memcached/python-rewrite

  1. Trusty Tahr (14.04)
  2. python-rewrite
  3. Merge into trunk
Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Hello Felipe,

Thanks for this contribution. I made some inline comments, required to be fixed. Also i have a few suggestions for improving.

On the lint side,

- Remove the 'tags' section on the metadata.yaml file.
- Add the categories: ["system"] on the metadata.yaml file.

On the test side,

- Remove the pre_install_hooks code.
- Add test coverage for the method cache_relation_departed
- Add test coverage for the method upgrade_charm

On the memcache_utils file.

- Please instead of create your own template rendering method, please see:
hooks/charmhelpers/core/templating.py
- Add test coverage for method revoke_access

review: Needs Fixing

« Back to merge proposal