Merge lp://staging/~freyes/charm-helpers/ufw into lp://staging/charm-helpers
Status: | Merged |
---|---|
Merged at revision: | 263 |
Proposed branch: | lp://staging/~freyes/charm-helpers/ufw |
Merge into: | lp://staging/charm-helpers |
Diff against target: |
396 lines (+387/-0) 2 files modified
charmhelpers/contrib/network/ufw.py (+182/-0) tests/contrib/network/test_ufw.py (+205/-0) |
To merge this branch: | bzr merge lp://staging/~freyes/charm-helpers/ufw |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jorge Niedbalski (community) | Approve | ||
Review via email: mp+243714@code.staging.launchpad.net |
This proposal supersedes a proposal from 2014-12-04.
Description of the change
Dear Charmers,
Here I'm proposing a module to manage access to services using ufw, this is a helpful module to secure services that don't provide built-in mechanisms to control accesses (for example memcached).
Here are some examples on how the API is used:
- open SSH port for subnet 10.0.3.0/24:
>>> from charmhelpers.
>>> ufw.enable()
>>> ufw.grant_
- open service by name as defined in /etc/services:
>>> from charmhelpers.
>>> ufw.enable()
>>> ufw.service('ssh', 'open')
- close service by port number:
>>> from charmhelpers.
>>> ufw.enable()
>>> ufw.service('4949', 'close') # munin
Thanks,
Felipe,
Thanks again for contributing, please review the inline comments.
Also please add some ipv6 cases to your tests.
Other than that. LGTM.