Code review comment for lp://staging/~freyes/charm-helpers/ufw

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Felipe,

Thanks again for contributing, please review the inline comments.

Also please add some ipv6 cases to your tests.

Other than that. LGTM.

review: Needs Fixing

« Back to merge proposal