Code review comment for lp://staging/~free.ekanayaka/storm/tpc-support

Revision history for this message
Stuart Bishop (stub) wrote :

The new Connection.rollback(xid) has some broken behavior - if the rollback fails because of a disconnection error, the method succeeds.In this case, it should instead re-raise the exception.

Apart from this problem, I see nothing else blocking this from landing (beyond a second review :) )

review: Approve

« Back to merge proposal