Code review comment for lp://staging/~free.ekanayaka/storm/schema-uri-in-testresource

Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

Hi Gustavo,

so you mean a parameter object? like:

class ZStormResourceManagerDatabase(object):

    def __init__(self, name, uri, schema, schema_uri=None):
        ...

and then

   manager = ZStormResourceManager([ZStormResourceManagerDatabase(...),
                                    ZStormResourceManagerDatabase(...),
                                    ...])

Alternatively instead of passing this information in the constructor we could have a configuration method like:

class ZStormResourceManager(object):

    def add_database(self, name, uri, schema, schema_uri=None):
        ...

« Back to merge proposal