Code review comment for lp://staging/~free.ekanayaka/storm/fix-order-by-expressions-in-ref-set

Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

Thinking about it, a third option would be to have both approaches in place:

        elif isinstance(property, SuffixExpr):
            # We know how to handle this specific case, so be smart
            property.expr = self.resolve(property.expr)
            return property
        elif isinstance(property, Expr):
            # This is a generic expression that we don't handle (yet), so
            # just take it as it is
            return property

« Back to merge proposal