Code review comment for lp://staging/~frankban/charms/trusty/juju-gui/new-test-and-server-deps

Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Update dependencies + other fixes.

Update the GUI server dependencies:
websocket-client, jujuclient, juju=deployer.
Also included in the dependencies repo
the new websocket-client requirements.

Update selenium to the latest version
(2.43.0) so that the functional tests
pass on Firefox 32. The download cache
has been updated accordingly.

Fix how the suite detects if it is running
on a local environment: do not use the
environment name (unreliable), but retrieve
the environment type instead.

Fix the WebSocket client used when running
functional tests to reflect changes in the
new websocket-client.

QA:
run the test suite on precise and trusty:
assuming your ec2 trusty environment is
called ec2-trusty and your ec2 precise one
is called ec2-precise, run the following:

     make test JUJU_ENV=ec2-trusty
     make test JUJU_ENV=ec2-precise

As you already know, the functional tests
take a while.

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/136570043

https://codereview.appspot.com/136570043/

« Back to merge proposal