Juju Charms Collection
juju-gui package

Code review comment for lp://staging/~frankban/charms/precise/juju-gui/venv-fixes

  1. Precise Pangolin (12.04)
  2. venv-fixes
  3. Merge into trunk
Revision history for this message
Gary Poster (gary) wrote :

LGTM with consideration of comment.

https://codereview.appspot.com/26530043/diff/20001/tests/00-setup
File tests/00-setup (right):

https://codereview.appspot.com/26530043/diff/20001/tests/00-setup#newcode35
tests/00-setup:35: [ $retcode -eq 0 ] && touch $ACTIVATE || rm -f
$ACTIVATE
The only downside to this is that, since the $ACTIVATE is removed, you
can't use it to diagnose issues. What would you think of touching
$TEST_REQUIREMENTS in the failure case, instead?

https://codereview.appspot.com/26530043/

« Back to merge proposal