Merge lp://staging/~frankban/charms/precise/juju-gui/trusty-defaults into lp://staging/~juju-gui/charms/trusty/juju-gui/trunk
Proposed by
Francesco Banconi
Status: | Merged |
---|---|
Merged at revision: | 183 |
Proposed branch: | lp://staging/~frankban/charms/precise/juju-gui/trusty-defaults |
Merge into: | lp://staging/~juju-gui/charms/trusty/juju-gui/trunk |
Diff against target: |
234 lines (+42/-26) 9 files modified
.lbox (+1/-1) HACKING.md (+16/-5) Makefile (+2/-1) README.md (+1/-1) hooks/install (+6/-2) revision (+1/-1) tests/deploy.py (+6/-5) tests/example.py (+5/-6) tests/test_deploy.py (+4/-4) |
To merge this branch: | bzr merge lp://staging/~frankban/charms/precise/juju-gui/trusty-defaults |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju GUI Hackers | Pending | ||
Review via email:
|
Description of the change
Use trusty as default target series.
Switched to lp:~juju-gui/charms/trusty/juju-gui/trunk
(I'll send an email after this branch is landed).
Change "make deploy" to install the trusty charm by default.
Also run "apt-get update" at the beginning of the install hook.
Tests: `make unittest`.
To post a comment you must log in.
Reviewers: mp+216695_ code.launchpad. net,
Message:
Please take a look.
Description:
Use trusty as default target series.
Switched to lp:~juju-gui/charms/trusty/juju-gui/trunk
(I'll send an email after this branch is landed).
Change "make deploy" to install the trusty charm by default.
Also run "apt-get update" at the beginning of the install hook.
Tests: `make unittest`.
https:/ /code.launchpad .net/~frankban/ charms/ precise/ juju-gui/ trusty- defaults/ +merge/ 216695
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/90220043/
Affected files (+44, -26 lines): deploy. py
M .lbox
M HACKING.md
M Makefile
M README.md
A [revision details]
M hooks/install
M revision
M tests/deploy.py
M tests/example.py
M tests/test_
Index: .lbox
=== modified file '.lbox'
--- .lbox 2013-06-04 16:52:52 +0000
+++ .lbox 2014-04-22 09:27:01 +0000
@@ -1,1 +1,1 @@
-propose -cr -for lp:~juju-gui/charms/precise/juju-gui/trunk
+propose -cr -for lp:~juju-gui/charms/trusty/juju-gui/trunk
Index: HACKING.md
=== modified file 'HACKING.md'
--- HACKING.md 2014-04-15 14:17:12 +0000
+++ HACKING.md 2014-04-22 10:28:39 +0000
@@ -30,7 +30,7 @@
The command above will run as root and install the required deb packages.
Next, you need the bzr branch. We work from /code.launchpad .net/~juju- gui/charms/ precise/ juju-gui/ trunk). /code.launchpad .net/~juju- gui/charms/ trusty/ juju-gui/ trunk).
-[lp:~juju-gui/charms/precise/juju-gui/trunk](https:/
+[lp:~juju-gui/charms/trusty/juju-gui/trunk](https:/
You could start hacking now, but there's a bit more to do to prepare for
running and writing tests.
@@ -112,7 +112,7 @@
make clean /path/to/ charm/repo local:precise/ juju-gui /path/to/ charm/repo local:trusty/ juju-gui
juju bootstrap
- juju deploy --repository=
+ juju deploy --repository=
juju expose juju-gui
The second one is just running "make deploy":
@@ -127,10 +127,10 @@
created, the testing virtualenv.
The `make deploy` command also supports specifying the OS version used to
-deploy the local charm. By default a precise machine is created, but you
can
-run the following to deploy the charm on trusty:
+deploy the local charm. By default a trusty machine is created, but you can
+run the following to deploy the charm on precise:
- make deploy SERIES=trusty
+ make deploy SERIES=precise
Now you are working with a test run, as described in /juju.ubuntu. com/docs/ write-charm. html#test- run>. The
<https:/
@@ -166,6 +166,17 @@
All of this is described in more detail on the Juju site: this is an
introduction to the process.
+## Making charm releases ##
+
+The same code base is used for both precise and trusty releases.
+Releasing the charm is done by pushing changes from the development branch
to
+the precise and trusty release branches.
+The branches live in the following locations:
+
+- development branch: `lp:~juju-gui/charms/trusty/juju-gui/trunk`
+- precise release: `lp:charms/juju-gui`
+- trusty release: `lp:charms/trusty/juju-gui`
+
## Upgrading the local releases repository ##
The charm, in the default juju-gui-source configuration ("local"), deploys
the
...