lp://staging/~frankban/charms/precise/juju-gui/trusty-defaults
- Get this branch:
- bzr branch lp://staging/~frankban/charms/precise/juju-gui/trusty-defaults
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 234 lines (+42/-26)9 files modified.lbox (+1/-1)
HACKING.md (+16/-5)
Makefile (+2/-1)
README.md (+1/-1)
hooks/install (+6/-2)
revision (+1/-1)
tests/deploy.py (+6/-5)
tests/example.py (+5/-6)
tests/test_deploy.py (+4/-4)
Branch information
- Owner:
- Francesco Banconi
- Status:
- Development
Recent revisions
- 182. By Francesco Banconi
-
Avoid clickjacking.
Update the builtin and legacy servers to send
the proper X-Frame-Options header so that
iframing is denied from extraneous origins.The legacy server has been update to ensure
clickjacking is not possible on jujucharms.com.Tests: `make unittest`.
QA:
- juju bootstrap an environment;
- run `make deploy`;
- wait for the GUI to be ready/started;
- open the GUI with the browser and log in;
- prepare an HTML page like the following, replacing
<GUI UNIT HOSTNAME> with the address of the GUI in
your environment:<!DOCTYPE html>
<html>
<head>
<title>test clickjacking</title>
</head>
<body>
<iframe src="https://<GUI UNIT HOSTNAME>"
height="800" width="1000">< /iframe>
</body>
</html>- open the test page above with the browser,
the iframe should be empty;
- switch to the legacy server:
`juju set juju-gui builtin-server= false`;
- wait a minute for the config-changed hook
to complete;
- open the test page above with the browser,
the iframe should be empty;
- destroy the environment.R=jeff.pihach
CC=
https://codereview. appspot. com/88090048 - 179. By Francesco Banconi
-
Trusty charm.
Make the charm work on trusty.
Also update the charm documentation.QA:
Please run the unit and functional tests
using both precise and trusty.
Follow the instructions in the HACKING file.R=bac
CC=
https://codereview. appspot. com/88100044
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/charms/juju-gui