Juju Charms Collection
juju-gui package

Code review comment for lp://staging/~frankban/charms/precise/juju-gui/server-auth

  1. Precise Pangolin (12.04)
  2. server-auth
  3. Merge into trunk
Revision history for this message
Francesco Banconi (frankban) wrote :

Thank you both for the reviews!

> LGTM, impressive work indeed. One trivial below. Also, consider only
saying "log
> in" and "logged in" when used as a verb, but "login" when a noun, i.e.
"login
> request".

Done.

https://codereview.appspot.com/11725044/diff/9001/server/guiserver/manage.py#newcode86
> server/guiserver/manage.py:86: 'of the bootstrap/state node as
 returned by juju
> status.')
> Double quotes around "juju status", maybe?

Done.

https://codereview.appspot.com/11725044/

« Back to merge proposal