LGTM with trivial comment request. Doing QA now.
https://codereview.appspot.com/26130043/diff/1/hooks/utils.py File hooks/utils.py (right):
https://codereview.appspot.com/26130043/diff/1/hooks/utils.py#newcode550 hooks/utils.py:550: '--find-links', 'file:///{}'.format(deps), '-r', requirements yay, nice
https://codereview.appspot.com/26130043/diff/1/server-requirements.pip File server-requirements.pip (right):
https://codereview.appspot.com/26130043/diff/1/server-requirements.pip#newcode19 server-requirements.pip:19: # Note: the order of the following dependencies is important! Would be nice to indicate why.
https://codereview.appspot.com/26130043/diff/1/test-requirements.pip File test-requirements.pip (right):
https://codereview.appspot.com/26130043/diff/1/test-requirements.pip#newcode32 test-requirements.pip:32: -r server-requirements.pip cool. I didn't know about this feature.
https://codereview.appspot.com/26130043/diff/1/tests/test_utils.py File tests/test_utils.py (right):
https://codereview.appspot.com/26130043/diff/1/tests/test_utils.py#newcode1117 tests/test_utils.py:1117: mock.call( wow. cool that you can do this.
https://codereview.appspot.com/26130043/
« Back to merge proposal
LGTM with trivial comment request. Doing QA now.
https:/ /codereview. appspot. com/26130043/ diff/1/ hooks/utils. py
File hooks/utils.py (right):
https:/ /codereview. appspot. com/26130043/ diff/1/ hooks/utils. py#newcode550 //{}'.format( deps), '-r',
hooks/utils.py:550: '--find-links', 'file:/
requirements
yay, nice
https:/ /codereview. appspot. com/26130043/ diff/1/ server- requirements. pip requirements. pip (right):
File server-
https:/ /codereview. appspot. com/26130043/ diff/1/ server- requirements. pip#newcode19 requirements. pip:19: # Note: the order of the following
server-
dependencies is important!
Would be nice to indicate why.
https:/ /codereview. appspot. com/26130043/ diff/1/ test-requiremen ts.pip ts.pip (right):
File test-requiremen
https:/ /codereview. appspot. com/26130043/ diff/1/ test-requiremen ts.pip# newcode32 ts.pip: 32: -r server- requirements. pip
test-requiremen
cool. I didn't know about this feature.
https:/ /codereview. appspot. com/26130043/ diff/1/ tests/test_ utils.py
File tests/test_utils.py (right):
https:/ /codereview. appspot. com/26130043/ diff/1/ tests/test_ utils.py# newcode1117 utils.py: 1117: mock.call(
tests/test_
wow. cool that you can do this.
https:/ /codereview. appspot. com/26130043/