> Do you think we can drop the additional exclude-tables argument, but accept
> the rest of the patch?
That is fine by me. I was not clear on what the original intention of the tool was, so your arguments make sense to me.
As you said the issues I have run into are being patched and handled so I don't need the generic exclude tables ability. I have been given a command to manually rename the metadata_id_seq sequence to annotation_id_seq, and I will just have to remove extraneous backup tables that someone created in one of our databases to make it clean before migration.
I have reverted my most recent changes, only leaving the "--exclude-table=change_package_lock_request*" and s/account/account-1/ fixes, as well as leaving printing the dump/restore commands being run.
> Do you think we can drop the additional exclude-tables argument, but accept
> the rest of the patch?
That is fine by me. I was not clear on what the original intention of the tool was, so your arguments make sense to me.
As you said the issues I have run into are being patched and handled so I don't need the generic exclude tables ability. I have been given a command to manually rename the metadata_id_seq sequence to annotation_id_seq, and I will just have to remove extraneous backup tables that someone created in one of our databases to make it clean before migration.
I have reverted my most recent changes, only leaving the "--exclude- table=change_ package_ lock_request* " and s/account/ account- 1/ fixes, as well as leaving printing the dump/restore commands being run.