Code review comment for lp://staging/~fnordahl/openstack-charm-testing/kv3-update

Revision history for this message
Billy Olsen (billy-olsen) wrote :

@Alex - I never took it as snarky :-)

My comment was mostly to suggest that multiple units should be handled differently since a different address is important here. A subsequent merge proposal can be provided for the HA/multiple unit case. I see no reason to hold this change up based on the multiple unit scenario as the previous cases using juju-deployer do not properly handle that case either.

« Back to merge proposal