Merge lp://staging/~florian-angermeier/contractor/filter-functions-based-on-file-size into lp://staging/contractor/0.3
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | xapantu | ||||
Approved revision: | 147 | ||||
Merged at revision: | 137 | ||||
Proposed branch: | lp://staging/~florian-angermeier/contractor/filter-functions-based-on-file-size | ||||
Merge into: | lp://staging/contractor/0.3 | ||||
Diff against target: |
710 lines (+326/-22) 13 files modified
src/Contract.vala (+60/-0) src/ContractDirectory.vala (+2/-1) src/ContractFile.vala (+42/-1) src/ContractKeyFile.vala (+44/-3) src/ContractMatcher.vala (+59/-4) src/ContractSorter.vala (+4/-2) src/ContractSource.vala (+4/-2) src/DBusService.vala (+95/-1) src/FileEnumerator.vala (+2/-1) src/FileService.vala (+4/-2) src/MimeTypeManager.vala (+4/-2) src/String.vala (+4/-2) src/Translations.vala (+2/-1) |
||||
To merge this branch: | bzr merge lp://staging/~florian-angermeier/contractor/filter-functions-based-on-file-size | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
xapantu (community) | Approve | ||
Review via email: mp+271211@code.staging.launchpad.net |
This proposal supersedes a proposal from 2015-09-13.
Commit message
Implement filter functions based on file size:
* Get the max file size (int64, size in bytes) from a .contract file (optional key MaxFileSize)
* Add methods to the D-Bus service:
- get_contracts_
- get_contracts_
- get_contracts_
Add documentation
Description of the change
Implement filter functions based on file size:
* Get the max file size (int64, size in bytes) from a .contract file (optional key MaxFileSize)
* Add methods to the D-Bus service:
- get_contracts_
- get_contracts_
- get_contracts_
Add documentation
Nice work, thanks :)
See below a few comments about code style and some other things.
We also need documentations for the public methods to get this merged, which will be used to generate the api docs (see other files (e.g. the widgets are well documented) if you are looking for examples).