Code review comment for lp://staging/~fgallaire/bzr/fix-gmtime-lite

Revision history for this message
Florent Gallaire (fgallaire) wrote :

> Good work thanks !


> ./bzrlib/doc_generate/ tt = time.gmtime(t)
> ./bzrlib/doc_generate/ tt = time.gmtime(t)
> ./bzrlib/doc_generate/ tt = time.gmtime(t)
> ./bzrlib/ date_string = time.strftime('%Y-%m-%dT%H:%M',
> time.gmtime())
> (I don't think they matter as much but being consistent and using
> osutils.gmtime() instead of time.gmtime() remove confusion about why the code
> base would use two different versions).

I haven't replaced time.gmtime() and time.gmtime(time.time()) because they run against the present time which is not buggy, will only be if we still use bazaar on 32-bit platforms in more than 20 years.

Do you want I fix it even so ?

> Final administrativia: please sign the CLA


« Back to merge proposal