Code review comment for lp://staging/~fgallaire/bzr/fix-gmtime-lite

Revision history for this message
Florent Gallaire (fgallaire) wrote :

> > but you can easily test it.
> No we can't (at least I and Richard can't).
> That's the issue here, without testing on windows, nothing can really be
> fixed.

I have set up a Windows VM, you can see a screenshot of the bug in the report I filed.

> > Very unhappy with your Test-Driven Development practice because I was trying
> to make code cleaner and found that:
> What is making you unhappy ?

Look at the commit: awful replicated and spaghetti code justified by an useless test.

« Back to merge proposal