Session Menu

Code review comment for lp://staging/~feng-kylin/indicator-session/indicatorForKylin

Revision history for this message

Charles Kerr (charlesk) wrote on 2014-07-15:

* GIOChannel isn't closed

* all the temp_strs before NAME= are leaked

* if NAME= isn't found, os_release_name is uninitialized when passed to g_strjoin()

* help_label is leaked

* "Help" should be _("Help")

* if NAME= isn't found, str_array_split is uninitialized when passed to g_strfreev()

review: Needs Fixing