Merge lp://staging/~fboucault/webbrowser-app/address_bar_populate_selected_suggestion into lp://staging/webbrowser-app/staging
Proposed by
Florian Boucault
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~fboucault/webbrowser-app/address_bar_populate_selected_suggestion |
| Merge into: | lp://staging/webbrowser-app/staging |
| Prerequisite: | lp://staging/~osomon/webbrowser-app/qmltests |
| Diff against target: |
349 lines (+125/-47) 4 files modified
src/app/webbrowser/Browser.qml (+47/-3) src/app/webbrowser/NavigationBar.qml (+1/-1) src/app/webbrowser/Suggestions.qml (+9/-1) tests/qmltests/webbrowser-app/tst_Suggestions.qml (+68/-42) |
| To merge this branch: | bzr merge lp://staging/~fboucault/webbrowser-app/address_bar_populate_selected_suggestion |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phablet Team | Pending | ||
|
Review via email:
|
|||
Commit message
Address bar suggestions:
* When highlighting a suggestion, copy it to the address bar.
* Preserve search suggestions when going up/down
* Add static search suggestion as first element
Description of the change
Address bar suggestions:
* When highlighting a suggestion, copy it to the address bar.
* Preserve search suggestions when going up/down
* Add static search suggestion as first element
To post a comment you must log in.
Unmerged revisions
- 1657. By Florian Boucault
-
Fix failing tests
- 1656. By Florian Boucault
- 1655. By Florian Boucault
-
Removed rev 1653
- 1654. By Florian Boucault
-
Merged qmltests
- 1653. By Florian Boucault
-
More reliable test Suggestions:
:test_list_ of_suggestions_ limits - 1652. By Florian Boucault
-
Merged qmltests
- 1651. By Florian Boucault
-
Add static search suggestion as first element
- 1650. By Florian Boucault
-
Cleaner
- 1649. By Florian Boucault
-
Preserve search suggestions when going up/down
- 1648. By Florian Boucault
-
First step: when highlighting a suggestion, copy it to the address bar.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
