Merge lp://staging/~facundo/magicicada-server/temp-file-renamed-on-commit into lp://staging/magicicada-server
Proposed by
Facundo Batista
| Status: | Merged |
|---|---|
| Approved by: | Natalia Bidart |
| Approved revision: | 40 |
| Merged at revision: | 42 |
| Proposed branch: | lp://staging/~facundo/magicicada-server/temp-file-renamed-on-commit |
| Merge into: | lp://staging/magicicada-server |
| Diff against target: |
186 lines (+61/-11) 5 files modified
src/server/content.py (+2/-1) src/server/diskstorage.py (+23/-6) src/server/tests/test_diskstorage.py (+29/-2) src/server/tests/test_upload.py (+3/-1) src/server/upload.py (+4/-1) |
| To merge this branch: | bzr merge lp://staging/~facundo/magicicada-server/temp-file-renamed-on-commit |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Natalia Bidart | Approve | ||
|
Review via email:
|
|||
Commit message
In an Upload, move the file in DiskStorage to final name only on commit.
Description of the change
In an Upload, move the file in DiskStorage to final name only on commit.
To post a comment you must log in.
Revision history for this message
| Natalia Bidart (nataliabidart) | # |
Revision history for this message
| Facundo Batista (facundo) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Comments replied, if all is ok let's land this.