Code review comment for lp://staging/~fabien-morin/unifield-server/fm_whitelist_model

Revision history for this message
Fabien MORIN (fabien-morin) wrote :

There is no CSV file involed just a dict. Before this branch, all models that don't need to use sync where listed here. But many times some models were created and there where not added in this list (done through forgetfulness, I supposed). This result in creation of sdref for objects that don't need it, making the creation of this objects themselves much slower for nothing. I discover this problem during the performance improvement process.

The idea beside this change is to reverse the list by listing only the models that need a sdref.

The new hardcoded list has not been written by hand but generated by script I written for that purpose. So it should ends up with exactly the same result. To be sure, I already launch all our unit tests with this branch without any problems. Once testfield is woking again, I can also launch all the testfield tests to check that nothing is broken. But as this list has been generated, there should not be any surprise.

« Back to merge proposal