Code review comment for lp://staging/~ev/ubuntu-ci-services-itself/cli-packaging

Revision history for this message
Vincent Ladeuil (vila) wrote :

I'm not a packaging expert so I'm mostly learning here ;)

9 + if os.path.exists(component_dir):
10 + os.chdir(component_dir)
11 + else:
12 + # We're probably in the component dir (like when we're called from the
13 + # Debian package build).
14 + component_dir = os.getcwd()

I thought setup.py and debian packaging where completely separate so I don't quite get why/when this is involved, can you shed some light on what commands you use to trigger that ?

72 === added file 'ci-utils/debian/copyright'
73 --- ci-utils/debian/copyright 1970-01-01 00:00:00 +0000
74 +++ ci-utils/debian/copyright 2014-03-05 11:28:37 +0000

Oooh, that's all it takes ! Will fix my packages accordingly ;)

107 +override_dh_python2:
108 + dh_python2 --no-guessing-deps

What does that do ?

The rest looks similar to what I use myself so I can only approve ;)

review: Approve

« Back to merge proposal