Code review comment for lp://staging/~ev/ubuntu-ci-services-itself/better-structure-and-logging

On 10 March 2014 03:06, Andy Doan <email address hidden> wrote:
> This is close, but I just noticed the ppa-cleaner isn't running:
>
> Unable to use unit_config(/srv/ppa_django/code/ppa-assigner/../unit_config), defaulting values
> ERROR: oauth settings are required by this command:
> OAUTH_CONSUMER_KEY
> OAUTH_TOKEN
> OAUTH_TOKEN_SECRET
>
> I think this is because this type of deployment requires CONFDIR to get get set. Is CONFDIR a gunicorn specific thing or something, I'm not sure where that gets set at?

CONFDIR is something I invented to let us set a variable configuration
path rather than having it hardcoded everywhere, which would've made
our charms not mergeable with trunk. I think we'll need to teach the
upstart charm to support custom stanzas or specifically the
environment variables to set. We can then tell the ppa-cleaner to try
looking under CONFIDR for the unit_config first.

My rationale is this: we shouldn't be deploying configuration on top
of code. That's a recipe for disaster.