1402 +# Ticket System 1403 +BASE_IMAGE_DEFAULT = _cfg.get('base_image', '') 1404 +SERIES_DEFAULT = _cfg.get('series', '') 1405 +MASTER_PPA_DEFAULT = _cfg.get('master_ppa', '') 1406 + 1407 +# PPA Assigner 1408 +LAUNCHPAD_PPA_USER = _cfg.get('launchpad_user', None) 1409 +LAUNCHPAD_API_BASE = _cfg.get('launchpad_api_base', 1410 + 'https://api.launchpad.net/1.0') 1411 +OAUTH_CONSUMER_KEY = _cfg.get('oauth_consumer_key', None) 1412 +OAUTH_TOKEN = _cfg.get('oauth_token', None) 1413 +OAUTH_TOKEN_SECRET = _cfg.get('oauth_token_secret', None) 1414 +OAUTH_REALM = _cfg.get('oauth_realm', 'https://api.launchpad.net/') 1415 +PPA_PATTERN = _cfg.get('ppa_pattern', r'ci-pool-\d+')
do we really want this stuff in our charm? its already in the components settings.py file and just seems like it will lead to confusion if we ever need to add/remove/change one of these settings.
« Back to merge proposal
1402 +# Ticket System 'base_image' , '') 'master_ ppa', '') 'launchpad_ user', None) 'launchpad_ api_base' , /api.launchpad. net/1.0') 'oauth_ consumer_ key', None) 'oauth_ token', None) 'oauth_ token_secret' , None) 'oauth_ realm', 'https:/ /api.launchpad. net/') 'ppa_pattern' , r'ci-pool-\d+')
1403 +BASE_IMAGE_DEFAULT = _cfg.get(
1404 +SERIES_DEFAULT = _cfg.get('series', '')
1405 +MASTER_PPA_DEFAULT = _cfg.get(
1406 +
1407 +# PPA Assigner
1408 +LAUNCHPAD_PPA_USER = _cfg.get(
1409 +LAUNCHPAD_API_BASE = _cfg.get(
1410 + 'https:/
1411 +OAUTH_CONSUMER_KEY = _cfg.get(
1412 +OAUTH_TOKEN = _cfg.get(
1413 +OAUTH_TOKEN_SECRET = _cfg.get(
1414 +OAUTH_REALM = _cfg.get(
1415 +PPA_PATTERN = _cfg.get(
do we really want this stuff in our charm? its already in the components settings.py file and just seems like it will lead to confusion if we ever need to add/remove/change one of these settings.