Code review comment for lp://staging/~ev/oops-repository/weighted-machines

Revision history for this message
Evan (ev) wrote :

On Mon, Mar 18, 2013 at 11:31 PM, Brian Murray <email address hidden> wrote:

> > + # Remember, we're ultimately tracking errors here, not systems, but
> we need
> > + # the system idnetifier to know the first occurance of an error in
> the
>
> typo: identifier
>
> > + # release for that machine.
> > + #
> > + # For the given release for today, the crash should be weighted by
> the
> > + # first time an error occured in the release for the system this
> came from.
> > + # Multipled by their weight and summed together, these form the
> numerator
>
> typo: Multiplied
>

Fixed as r66.

> Otherwise the rest of the merge proposal looks good to me.

Excellent. Thanks for the review!

« Back to merge proposal