Code review comment for lp://staging/~ev/daisy/weighted-tests

Revision history for this message
Brian Murray (brian-murray) wrote :

+def main(release, start, end, verbose=False):
+ start = start.replace(hour=0, minute=0, second=0, microsecond=0)
+ end = end.replace(hour=0, minute=0, second=0, microsecond=0)
+
+ creds = {'username': config.cassandra_username,
+ 'password': config.cassandra_password}
+ pool = pycassa.ConnectionPool(config.cassandra_keyspace,
+ config.cassandra_hosts, timeout=600,
+ credentials=creds)
+
+ systems = pycassa.ColumnFamily(pool, 'SystemsForErrorsByRelease')
+ uniquesys = pycassa.ColumnFamily(pool, 'UniqueSystemsForErrorsByRelease')
+
+ while start <= end:
+ target_date = start.replace(hour=0, minute=0, second=0, microsecond=0)

hour, minute, second and microsecond are replace two times for start.

RAMP_UP is set to 90 in two separate python files. Perhaps this should be a config option somewhere instead?

+def weight(release='Ubuntu 12.04'):

Well, we talked about that.

review: Approve

« Back to merge proposal