Code review comment for lp://staging/~ev/daisy/weighted-machines

On Mon, Mar 18, 2013 at 11:46 PM, Brian Murray <email address hidden> wrote:
>
> > + if hasattr(oopses, 'update_errors_by_release'):
> > + if (system_uuid and release) and not third_party:
>
> Why are you excluding third_party here? If we are recording errors for
> systems with third party packages shouldn't they factor into the
> calculation too?
>

Wow, great catch. My intent was to exclude non-Ubuntu releases, which I
mistook the third_party variable for. Fixed as r274.

> + oops_uuid = uuid.UUID(oops_id)
> > + oopses.update_errors_by_release(oops_uuid, system_uuid,
> release)
> > +
>
> In the build_errors_by_release tool you check to ensure that release
> starts with Ubuntu. Is the same check missing above?
>

Indeed it was. See above.

> > def attach_error_report(report, context):
> > # We only attach error report that was submitted by the client if
> we've hit
> > # a MaximumRetryException from Cassandra.
>
> The rest of the merge proposal looks good to me.
>

Excellent. Merging.