Code review comment for lp://staging/~ev/charms/trusty/jenkins-remote-slave/shell-fixes

Revision history for this message
Paul Larson (pwlars) wrote :

I think we should take a second look at the sed line, comments below. The resulting upstart job looks fine when I've tried it.

for the few extra lines we want, isn't the -x still useful? If not, I'm happy to remove it, I think it's worth having it there if something goes wrong.

« Back to merge proposal