Code review comment for lp://staging/~ev/activity-log-manager/add-whoopsie-back

I did some more research and found that in alm-cc.c file, inside function "alm_main_window_panel_init"

the #ifdef section is not being called. I tried fixing that with changing

#ifdef HAVE_WHOOPSIE to
#ifdef WHOOPSIE

and changing in src/Makefile.am

if HAVE_WHOOPSIE
libactivity_log_manager_la_CFLAGS += \
 $(POLKIT_CFLAGS) \
 -DGNOMECC_UI_DIR=\""$(gnomeccuidir)"\"
endif

to
if HAVE_WHOOPSIE
libactivity_log_manager_la_CFLAGS += \
 $(POLKIT_CFLAGS) \
 -DGNOMECC_UI_DIR=\""$(gnomeccuidir)"\" \
 -DWHOOPSIE
endif

Now the section isnide #ifdef is built, but there is a segfault with bt

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff6488c10 in g_type_check_instance_cast () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
(gdb) bt
#0 0x00007ffff6488c10 in g_type_check_instance_cast () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#1 0x00007fffb99244b0 in alm_main_window_panel_init (self=0x5555557b9b40) at alm-cc.c:63
#2 0x00007ffff648795f in g_type_create_instance () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#3 0x00007ffff646c718 in ?? () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#4 0x00007ffff646dce1 in g_object_newv () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#5 0x00007ffff646e4d0 in g_object_new_valist () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#6 0x00007ffff646e804 in g_object_new () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#7 0x000055555555de8c in ?? ()
#8 0x000055555555be47 in ?? ()
#9 0x00007ffff6467620 in g_closure_invoke () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#10 0x00007ffff6478f00 in ?? () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#11 0x00007ffff6480d11 in g_signal_emit_valist () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#12 0x00007ffff6480f92 in g_signal_emit () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#13 0x000055555555ebbb in ?? ()
#14 0x00007ffff646a7a0 in g_cclosure_marshal_VOID__BOXEDv () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#15 0x00007ffff64678e7 in ?? () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#16 0x00007ffff64802df in g_signal_emit_valist () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#17 0x00007ffff6480f92 in g_signal_emit () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#18 0x000055555555ed94 in ?? ()
#19 0x00007ffff76a849c in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#20 0x00007ffff6467620 in g_closure_invoke () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#21 0x00007ffff6478f00 in ?? () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#22 0x00007ffff6480996 in g_signal_emit_valist () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#23 0x00007ffff6480f92 in g_signal_emit () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#24 0x00007ffff77d777e in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0