Code review comment for lp://staging/~erigami/dockmanager/workrave-helper

Revision history for this message
Erigami (erigami) wrote :

> This is most likely generating a leak every time the DockItem appears/changes:
> gobject.timeout_add(5000, self.__poll_workrave)
> gobject.timeout_add(1000, self.__update_ui)
> You need to remove these timers if they aren't needed anymore and prevent
> adding them multiple times.

I don't think they cause a memory leak, since on_service_change() is called once on startup. If there are any changes in the Workrave interface, then DockManager should stop the helper, right?

Is there something that I'm missing?

review: Needs Resubmitting

« Back to merge proposal